Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footers are lost when using --from-context #921

Closed
1 task done
weichweich opened this issue Oct 17, 2024 · 1 comment
Closed
1 task done

Footers are lost when using --from-context #921

weichweich opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@weichweich
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description of the bug

Commit footers are lost when using git-cliff --from-context. It looks like they are not loaded when deserializing a commit.

Steps To Reproduce

Use the following context as input for the command git-cliff --from-context example.json --context and compare the input with the output.

example.json
[
    {
        "version": "0.22.0",
        "message": null,
        "commits": [
            {
                "id": "8505409899f154eb651ca8d3415a998b899df57b",
                "message": "commit message",
                "body": null,
                "footers": [
                    {
                        "token": "Closes",
                        "separator": " #",
                        "value": "889",
                        "breaking": false
                    }
                ],
                "group": "Bug fixes",
                "breaking_description": null,
                "breaking": false,
                "scope": "docs",
                "links": [],
                "author": {
                    "name": "Person A",
                    "email": "person.a@example.com",
                    "timestamp": 1728918198
                },
                "committer": {
                    "name": "Person A",
                    "email": "person.a@example.com",
                    "timestamp": 1728918198
                },
                "conventional": true,
                "merge_commit": false,
                "extra": null,
                "github": {
                    "username": null,
                    "pr_title": null,
                    "pr_number": null,
                    "pr_labels": [],
                    "is_first_time": false
                },
                "gitlab": {
                    "username": "Person A",
                    "pr_title": null,
                    "pr_number": null,
                    "pr_labels": [],
                    "is_first_time": false
                },
                "gitea": {
                    "username": null,
                    "pr_title": null,
                    "pr_number": null,
                    "pr_labels": [],
                    "is_first_time": false
                },
                "bitbucket": {
                    "username": null,
                    "pr_title": null,
                    "pr_number": null,
                    "pr_labels": [],
                    "is_first_time": false
                },
                "remote": {
                    "username": "Person A",
                    "pr_title": null,
                    "pr_number": null,
                    "pr_labels": [],
                    "is_first_time": false
                }
            }
        ],
        "commit_id": "85f392bd2c0e323835166a751eb12900a1ef8de6",
        "timestamp": 1729149570,
        "previous": {
            "version": "v0.21.0",
            "message": null,
            "commits": [],
            "commit_id": "c75bb36c88669b83d734fb5107e2d606a13f3a36",
            "timestamp": 1728550181,
            "previous": null,
            "repository": null,
            "extra": null,
            "github": {
                "contributors": []
            },
            "gitlab": {
                "contributors": []
            },
            "gitea": {
                "contributors": []
            },
            "bitbucket": {
                "contributors": []
            }
        },
        "repository": "...",
        "extra": null,
        "github": {
            "contributors": []
        },
        "gitlab": {
            "contributors": []
        },
        "gitea": {
            "contributors": []
        },
        "bitbucket": {
            "contributors": []
        }
    }
]

Expected behavior

Deserialize the footer from the context.

Screenshots / Logs

No response

Software information

  • Project version: 2.6.1

Additional context

No response

@weichweich weichweich added the bug Something isn't working label Oct 17, 2024
@orhun
Copy link
Owner

orhun commented Oct 17, 2024

duplicate #837
fixed in #920
going to be available with the next release :)

@orhun orhun closed this as not planned Won't fix, can't repro, duplicate, stale Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants