test(git): find upstream remote when using ssh #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
==========================================
+ Coverage 41.72% 42.42% +0.71%
==========================================
Files 21 21
Lines 1678 1695 +17
==========================================
+ Hits 700 719 +19
+ Misses 978 976 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
orhun
reviewed
Oct 20, 2024
kemitix
force-pushed
the
ssh-remotes
branch
2 times, most recently
from
2ea058f to
87fc703
Compare
The `upstream_remote` function was relying on `url::Url::parse` to extract the `owner` and `repo` from the `url`. But that only works when the repo is cloned using a URL, e.g. `https://github.com/orhun/git-cliff.git`. However, this would fail to parse when cloned using SSH, e.g. `git@github.com:orhun/git-cliff.git`. If the url::URL::parser fails, we now try to parse an SSH remote in the format `git@hostname:owner/repo.git`. The error from `upstream_remote` also notes that a posible reason for it failing would be that the `HEAD` is detached.
orhun
reviewed
Oct 21, 2024
orhun
approved these changes
Oct 21, 2024
|
Thanks for the PR! |
orhun
changed the title
|
Congrats on merging your first pull request! ⛰️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When looking for the
ownerandrepoof the remote for the currentHEAD, we will now try to parse the SSH format of a remote if it fails to match an HTTPS format of a remote.Motivation and Context
When the
git-cliffrepo is cloned for development using the SSH protocol, the testrepo::test::git_upstream_remotefails.The
upstream_remotefunction was relying onurl::Url::parseto extract theownerandrepofrom theurl. But that only works when the repo is cloned using HTTPS, e.g.https://github.com/orhun/git-cliff.git. However, this would fail to parse when cloned using SSH, e.g.git@github.com:orhun/git-cliff.git.Now, if the
url::URL::parserfails, we now try to parse an SSH remote in the formatgit@hostname:owner/repo.git.The error from
upstream_remotealso notes that a possible reason for it failing would be that theHEADis detached.How Has This Been Tested?
orhun/git-cliffrepo askemitix/git-cliffgit@github.com:kemitix/git-cliff.gitcargo test- all tests pass, includingrepo::test::git_upstream_remoteScreenshots / Logs (if applicable)
n/a
Types of Changes
Checklist: