Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADIOS2_USE_Endian_Reverse Broken #2700

Closed
ax3l opened this issue May 15, 2021 · 3 comments · Fixed by #2701
Closed

ADIOS2_USE_Endian_Reverse Broken #2700

ax3l opened this issue May 15, 2021 · 3 comments · Fixed by #2701

Comments

@ax3l
Copy link
Contributor

ax3l commented May 15, 2021

@eschnett reported in Spack that -DADIOS2_USE_Endian_Reverse=ON is broken: spack/spack#23643

adios2/helper/adiosMemory.cpp:32:22: error: no match for 'operator==' (operand types are 'const adios2::DataType' and 'const char [1]')
   32 |         if (destType == "")
      |             ~~~~~~~~ ^~ ~~
      |             |           |
      |             |           const char [1]
      |             const adios2::DataType

I can reproduce this with the latest master as of d654782

cmake -S . -B build -DADIOS2_USE_Endian_Reverse=ON
cmake --build build

cc @pnorbert @chuckatkins

@ax3l
Copy link
Contributor Author

ax3l commented May 15, 2021

I guess the right comparison would be something like destType == DataType::None or so?

@germasch
Copy link
Contributor

Yes, this should be destType == DataType::None, and it might even be that it was me who broke it. If so, a real long time ago...

@ax3l
Copy link
Contributor Author

ax3l commented May 15, 2021

Thanks, fix in #2701 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants