Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation Task not used #21

Closed
AlessandroPolidori opened this issue Jul 5, 2023 · 1 comment · Fixed by #22
Closed

Evaluation Task not used #21

AlessandroPolidori opened this issue Jul 5, 2023 · 1 comment · Fixed by #22
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AlessandroPolidori
Copy link
Contributor

AlessandroPolidori commented Jul 5, 2023

Description & Motivation

I want to add this issue in order to keep in "backlog" something we have to deal with sooner or later. Evaluation Task (inside quadra/tasks/base.py) is currently extended only by SegmentationEvaluation.
I recently had the necessity to add a new behavior to the prepare() function of the evaluation tasks and it would have been much easier having a real Evaluation Task class extended by all the evaluations. I already opened the pr but is in draft rn (input_size propagation). Everything would be nicer and tidier if we refactor all the evaluation tasks and make them extend Evaluation.

@AlessandroPolidori AlessandroPolidori added the enhancement New feature or request label Jul 5, 2023
@AlessandroPolidori
Copy link
Contributor Author

I opened a pr (it's in draft because i still need to update the documentation)

@lorenzomammana lorenzomammana added this to the v1.1.0 milestone Jul 6, 2023
@lorenzomammana lorenzomammana linked a pull request Jul 6, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants