Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with 0.4.1 #130

Closed
mat813 opened this issue Sep 13, 2024 · 1 comment · Fixed by #134
Closed

Build fails with 0.4.1 #130

mat813 opened this issue Sep 13, 2024 · 1 comment · Fixed by #134

Comments

@mat813
Copy link

mat813 commented Sep 13, 2024

After #124 being fixed, the build now fails with:

$ tsc       
node_modules/@oruga-ui/theme-bulma/dist/types/bulma.d.ts:1:35 - error TS2307: Cannot find module '@oruga-ui/oruga-next' or its corresponding type declarations.

1 import type { OrugaOptions } from "@oruga-ui/oruga-next";
                                    ~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in node_modules/@oruga-ui/theme-bulma/dist/types/bulma.d.ts:1

But @oruga-ui/oruga-next is not defined as even a peer dependency. If I add it as a dev dep, it then fails because it can't find vue and vue-component-type-helpers, and if I add those two as dev deps, it finally builds.

My code is pretty simple, it's a generic module that I use to "patch" the config for all my projects:

import { bulmaConfig as originalBulmaConfig } from '@oruga-ui/theme-bulma';
import { merge } from 'lodash';

export const bulmaConfig = merge(
  originalBulmaConfig,

  {
    iconPack: 'fa',
    iconComponent: 'FontAwesomeIcon',
    field: {
      fieldInputWrapperClass: 'field-body',
    },
  },
);

I am unsure what is the correct fix for that use case.

@mlmoravek
Copy link
Member

Hey, thanks for the feedback!

Maybe we should add @oruga-ui/oruga-next as a peerDependency, like Oruga has vue as peerDependency?

Also, that vue-component-type-helpers is required, is a problem with the current Oruga version and documented here: oruga-ui/oruga#1038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants