Zod: only generates 200 response bodies

[Priddles]

What are the steps to reproduce this issue?

1. Use an input target with a path that has multiple responses.

Example

paths:
  /foo:
    get:
      responses:
        "200":
          $ref: "#/components/responses/Success"
        "202":
          $ref: "#/components/responses/SuccessAsync"
        "400":
          $ref: "#/components/responses/Error"

2. Generate using Zod client.

What happens?

Only one Zod schema for the 200 response body is generated.

What were you expecting to happen?

Zod schemas for all possible responses to be generated.

Any logs, error output, etc?

None.

Any other comments?

Appears to be hard-coded:

const response = spec?.[verb]?.responses?.['200'] as

What versions are you using?

Operating System: MacOS 14.4.1
Package Version: 6.28.2
Browser Version: N/A

[melloware]

Similar to this issue: #1280

[melloware]

Isn't this https://orval.dev/reference/configuration/output#generateeachhttpstatus

The setting to generate for each HTTP status?

[Priddles]

@melloware That is a config option for the mocks, and it does not affect zod generation as far as I can tell.

[melloware]

Reopened i thought it did it for mocks and zod. I see now its just mocks.

[melloware]

You are right the code is only doing 200

const response = spec?.[verb]?.responses?.['200'] as
    | ResponseObject
    | ReferenceObject;

[melloware]

@Priddles is it just a matter of looping over the responses array and generating for each?

[Priddles]

@Priddles is it just a matter of looping over the responses array and generating for each?

Yes, I'd say so.

Some level of deduplication would be good, but definitiely a nice-to-have.

[TommoLeedsy]

@melloware I have a fix for this locally and will put a PR in tomorrow.

[melloware]

Ok assigned the ticket to you.

[Priddles]

@melloware @TommoLeedsy Thanks for the quick turnaround!

I saw it got released so I tried it out, but having some issues. Wasn't sure whether to open a new issue or not so putting it here.

I have a minimal reproducible example here.

The issues are:

1. It seems to be reading the config from the wrong object.
2. It generates a lot of MSW and Faker related code that has nothing to do with Zod.

[melloware]

I would open a new ticket.

[TommoLeedsy]

@Priddles Sorry yeah that's my mistake, I didn't realise I needed to add a new config option and just used an existing one instead. I have now added generateEachHttpStatus to the zod options. This should sort it. I can put a PR in today?

[melloware]

Yes @TommoLeedsy PR would be great.

[Priddles]

@melloware Do you know when the fix might be released?

[melloware]

Let me find out

[Priddles]

Working in latest release. Thanks! 🎉