Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix overzealous replacements of 'ver' in install.md #2255

Closed
wants to merge 1 commit into from
Closed

docs: fix overzealous replacements of 'ver' in install.md #2255

wants to merge 1 commit into from

Conversation

cactysman
Copy link

This pull request restores words that were being partially replaced with the version identifier in commit 6529d51.
Basically everything ending in or containing ver got messed up and included the version identifier.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Restores words that were being partially replaced with the version identifier in commit 6529d51.
@CLAassistant
Copy link

CLAassistant commented Dec 16, 2020

CLA assistant check
All committers have signed the CLA.

@cactysman
Copy link
Author

The versioned install docs for version 1.9 were built with these mistakes by the way, but I wasn't sure if I should address that in here too.
Please let me know.

@aeneasr
Copy link
Member

aeneasr commented Dec 21, 2020

Oh man, this update script is giving me headaches 🤣 I will keep this open to make sure to properly fix the replacement in the script so this doesn't happen again.

aeneasr added a commit that referenced this pull request Jan 12, 2021
@aeneasr aeneasr closed this in 17d9599 Jan 12, 2021
@cactysman cactysman deleted the fix-docs-install branch March 15, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants