From e3e7ed08f5ce47fc794bd5c093018cee51baf689 Mon Sep 17 00:00:00 2001 From: aeneasr <3372410+aeneasr@users.noreply.github.com> Date: Tue, 19 Jul 2022 17:02:43 +0200 Subject: [PATCH] fix: gosec false positives --- cmd/courier/watch.go | 1 + cmd/daemon/serve.go | 2 ++ 2 files changed, 3 insertions(+) diff --git a/cmd/courier/watch.go b/cmd/courier/watch.go index 852d4778eb5..6a12e18c041 100644 --- a/cmd/courier/watch.go +++ b/cmd/courier/watch.go @@ -55,6 +55,7 @@ func ServeMetrics(ctx cx.Context, r driver.Registry) { handler = otelx.NewHandler(n, "cmd.courier.ServeMetrics") } + // #nosec G112 - the correct settings are set by graceful.WithDefaults server := graceful.WithDefaults(&http.Server{ Addr: c.MetricsListenOn(), Handler: handler, diff --git a/cmd/daemon/serve.go b/cmd/daemon/serve.go index 2242647becc..a59a7d51e9a 100644 --- a/cmd/daemon/serve.go +++ b/cmd/daemon/serve.go @@ -125,6 +125,7 @@ func ServePublic(r driver.Registry, wg *sync.WaitGroup, cmd *cobra.Command, args handler = x.TraceHandler(handler) } + // #nosec G112 - the correct settings are set by graceful.WithDefaults server := graceful.WithDefaults(&http.Server{ Handler: handler, TLSConfig: &tls.Config{Certificates: certs, MinVersion: tls.VersionTLS12}, @@ -185,6 +186,7 @@ func ServeAdmin(r driver.Registry, wg *sync.WaitGroup, cmd *cobra.Command, args handler = x.TraceHandler(n) } + // #nosec G112 - the correct settings are set by graceful.WithDefaults server := graceful.WithDefaults(&http.Server{ Handler: handler, TLSConfig: &tls.Config{Certificates: certs, MinVersion: tls.VersionTLS12},