-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: populate email templates at delivery time, add plaintext defaults #1155
feat: populate email templates at delivery time, add plaintext defaults #1155
Conversation
persistence/sql/migrations/templates/20210307130559_courier_message_template.up.fizz
Show resolved
Hide resolved
d2bfc93
to
91655e4
Compare
LMK when good for another 👀 |
94c6ba3
to
43f05a7
Compare
I have resolved the e2e tests so this should work again - rerunning tests now. |
e2e test pass on master again, so the failures here are related to the changes in the PR |
yep, need to fix some things related to the e2e tests. |
43f05a7
to
9bf5900
Compare
Hey @aeneasr, I'm wondering - do you think we need the plaintext portion of the email at all, or can we just drop that? |
Yes, many email clients reject HTML versions as spam or do not display them correctly! |
okay cool, will keep plugging away on this one. |
de3581b
to
af824d8
Compare
seems something wonky is going on with the sdk |
@aeneasr ready for another review :) |
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 |
Thanks for the reviews, as always! Do you think we'll see this in v0.6? |
Yes of course :) |
Related issue
#1065
Proposed changes
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments