Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add new provider vk.com? #1234

Closed
0x000777 opened this issue Apr 15, 2021 · 6 comments
Closed

Can you add new provider vk.com? #1234

0x000777 opened this issue Apr 15, 2021 · 6 comments

Comments

@0x000777
Copy link

Can you add new provider vk.com?

please see documentation: https://vk.com/dev/authcode_flow_user

@NickUfer
Copy link
Contributor

NickUfer commented Apr 15, 2021

I worked on the integration of vk some time ago. I think the problem for me was that you register with a phone number and not with an email which was a bit odd. I wanted to investigate if this can be problematic but I never got there because of other stuff I had to do.

If the team says it is technically no problem to have a phone number instead of an email I can make a PR the next days.

Edit: It seems you cant get the phone number either. So everything usable is: userId, firstname, lastname, nickname, picture url

@0x000777
Copy link
Author

0x000777 commented Apr 15, 2021

no, that's not a problem. It doesn't matter how you are registered (via phone or email).
authorization is a copy of facebook

Use scope: email (https://vk.com/dev/permissions)

provider_vkontakte.ZIP

@sash2222
Copy link

Hello @NickUfer, it seems that the Generic provider is not suitable for VK due to such trifles that VK does not have an endpoint /.well-known, and Kratos expects it when using the Geenric provider and does not accept certain endpoints in the configuration manually: issuer_url, auth_url, token_url ...
Earlier, @Highter87 posted his version here, could you accept it or make your own implementation.
As for the email field, this is not so critical for us, the main thing is that the authorization works.
We would be very grateful to you.

@aeneasr
Copy link
Member

aeneasr commented Apr 22, 2021

It's not really common to ask maintainers or community members to "do something". You can open requests and share ideas but this is not a free buffet. Doing things costs time and as you can imagine we don't have much time maintaining these projects.

The best option to implement what you want is to implement it and make a PR. An alternative is to help support the ecosystem on GitHub Sponsors, Patreon or OpenCollective (click the sponsor button on the top right of this page). But that still does not mean the feature is implemented - it just means that we can spend a little bit more time or maybe even hire someone to help out with things like this.

Also, please adhere to the issue template.

@aeneasr
Copy link
Member

aeneasr commented Apr 22, 2021

Thank you for contributing to this repository by creating an issue!

Unfortunately, your issue lacks vital information, such as log files, the error message, the software version, your configuration or other pieces of the puzzle.

Please also ensure that your issue is appropriately formatted. If you do not know how to write markdown, you can find help here.

Helping you with your problem is only possible if you share this information, and it will save a lot of time of back and forth on your as well as our end!

For this reason, this repository uses issue templates which you can select when pressing "New issue". Please use one of those issue templates to fill in the required information. You can either create a new issue for this purpose and close this one, or leave a comment.

Do not edit the original post as we will not be notified when you do so.

If you do not provide the requested information, this issue will be closed.

@sash2222
Copy link


name: add VKONTAKTE OIDC provider.
about: The social network VKONTAKTE has a fairly large audience and many projects based on it. OAuth support would be great.

We will be corrected! But I didn't want to be respectful of the community. You are doing a great job!

Describe the solution you'd like

Apparently, Generic OIDC is not suitable for using VK because they have their own implementation in details, in particular, they do not have a standard / .well-know configuration distribution point for the protocol that Generic expects.
Judging by the code, we can use the FB provider as an example to create a provider for VK on its basis, registering the necessary endpoints and a method for receiving claims there.

Describe alternatives you've considered

Change Generic OIDC. Do not require the mandatory presence of ./well-know if endpoints are specified in the configuration.

Additional context

https://vk.com/dev.php?method=authcode_flow_user
logs.txt
Uierror.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants