feat(identities): add a state to identities

[thomasruiz]

Related issue

#598

Proposed changes

Add a disabled_at field in the identity model. If it is set, the account is disabled. Block session creation when the account is disabled.

Checklist

• I have read the contributing guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security
  vulnerability. If this pull request addresses a security. vulnerability, I
  confirm that I got green light (please contact
  security@ory.sh) from the maintainers to push
  the changes.
• I have added tests that prove my fix is effective or that my feature
  works.
• I have added or changed the documentation.

Further comments

This is draft just to make sure the implementation is correct. Tests and documentation are very much needed, but before going further, I'd rather have a validation from the maintainers.

[CLAassistant]

All committers have signed the CLA.

[aeneasr]

Thank you for the contribution! I think what I meant in the original issue was more along the lines of adding a State parameter that is an enum of the different states. That way, we don't have to rely on nil values but instead have a clear cut singular state object :)

[thomasruiz]

Would there be another state besides active and disabled? Having a date to know when the user was disabled is a good thing, it allows automatic cleanup and other things. We could have a state field and a state_changed_at but... I don't see any other state rather that active and disabled. :p

[zepatrik]

invited might be a possible candidate later on (e.g. to implement #595). I am pretty sure there will be some more coming up 😉

[thomasruiz]

Alright, I see the point. This should be more what you guys had in mind. It still needs tests, and I'm thinking about adding a PATCH method to the identities controller. What do you think?

[aeneasr]

Sorry @thomasruiz for dropping the ball on this. Would you still be open to work on this or have you proceeded to other work?

[thomasruiz]

@aeneasr I updated most of the tests but there is still a problem: I don't see how to update the openapi specs to regenerate the SDKs. I added state and state_changed_at to the response of the identities API.

[aeneasr]

To regenerate the SDK run make sdk in the root directory :)

[aeneasr]

I think this is ready for review right? :) If so can you please mark it as ready for review? Thank you! :)

[thomasruiz]

I think this is ready for review right? :) If so can you please mark it as ready for review? Thank you! :)

There you go! I hope I didn't mess anything up :)

[aeneasr]

Awesome! Just have two small things but this is basically good to merge! Could you also add a small section on the new identity state to the docs? :)

[aeneasr]

🙄 circle ci has an outage..

[thomasruiz]

[aeneasr]

🤣

[aeneasr]

Thank you so much, a job well done! :)