feat: add helper for starting kratos e2e #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
reviewed
Jun 29, 2021
Comment on lines
+25
to
+63
| func setup(t *testing.T, cmd *cobra.Command) driver.Registry { | ||
| conf, reg := internal.NewFastRegistryWithMocks(t) | ||
| _, admin := testhelpers.NewKratosServerWithCSRF(t, reg) | ||
| conf.MustSet(config.ViperKeyDefaultIdentitySchemaURL, "file://./stubs/identity.schema.json") | ||
| // setup command | ||
| cliclient.RegisterClientFlags(cmd.Flags()) | ||
| cmdx.RegisterFormatFlags(cmd.Flags()) | ||
| require.NoError(t, cmd.Flags().Set(cliclient.FlagEndpoint, admin.URL)) | ||
| require.NoError(t, cmd.Flags().Set(cmdx.FlagFormat, string(cmdx.FormatJSON))) | ||
| return reg | ||
| } | ||
|
|
||
| func exec(cmd *cobra.Command, stdIn io.Reader, args ...string) (string, string, error) { | ||
| stdOut, stdErr := &bytes.Buffer{}, &bytes.Buffer{} | ||
| cmd.SetErr(stdErr) | ||
| cmd.SetOut(stdOut) | ||
| cmd.SetIn(stdIn) | ||
| defer cmd.SetIn(nil) | ||
| if args == nil { | ||
| args = []string{} | ||
| } | ||
| cmd.SetArgs(args) | ||
| err := cmd.Execute() | ||
| return stdOut.String(), stdErr.String(), err | ||
| } | ||
|
|
||
| func execNoErr(t *testing.T, cmd *cobra.Command, args ...string) string { | ||
| stdOut, stdErr, err := exec(cmd, nil, args...) | ||
| require.NoError(t, err) | ||
| require.Len(t, stdErr, 0, stdOut) | ||
| return stdOut | ||
| } | ||
|
|
||
| func execErr(t *testing.T, cmd *cobra.Command, args ...string) string { | ||
| stdOut, stdErr, err := exec(cmd, nil, args...) | ||
| require.True(t, errors.Is(err, cmdx.ErrNoPrintButFail)) | ||
| require.Len(t, stdOut, 0, stdErr) | ||
| return stdErr | ||
| } |
There was a problem hiding this comment.
This part is now part of cmdx, maybe remove it in this go? I can also do that btw
There was a problem hiding this comment.
Ah yeah makes sense, I first have to wrap everything in new* funcs to make it pass. We can then do another pass and remove these helpers and move to ory/x. Would be great if you could do that. I think it makes sense to do it once this PR is merged
There was a problem hiding this comment.
They are already in ory/x 1:1, you can just remove them here and import instead. But we can also separate that.
There was a problem hiding this comment.
The method signatures are a bit different so I'd separate it
# Conflicts: # docs/docs/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Proposed changes
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further comments