feat: custom smtp header config #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emtammaru
force-pushed
the
feature/smtp_header_config
branch
from
49ca772
to
770cefe
Compare
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
+ Coverage 74.02% 74.03% +0.01%
==========================================
Files 260 260
Lines 12691 12696 +5
==========================================
+ Hits 9394 9399 +5
Misses 2672 2672
Partials 625 625
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple configuration option for passing custom headers to the SMTP server.
Related issue(s)
#1725
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
All automated tests pass for me locally, and I also confirmed with a manual test that the headers are propagated correctly to SES. One thing I'm not quite sure how to test is the yaml config json schema validation. It might be nice to add a
propertyNames.patternregex validation for the headers object and/or prohibit reserved headers likeTo,Subject, etc. But, it works with these minimal changes.