Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add hiring notice to README #2074

Merged
merged 3 commits into from
Dec 17, 2021
Merged

fix: add hiring notice to README #2074

merged 3 commits into from
Dec 17, 2021

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Dec 17, 2021

Adds a notice that Ory is hiring to the top of README.
When this is approved, I would make the same changes to hydra etc.
As discussed with @BlueAcidFrog

@aeneasr
Copy link
Member

aeneasr commented Dec 17, 2021

Might make sense to set this in meta as a separate section or in the adopters file? then it's synced everywhere

@vinckr
Copy link
Member Author

vinckr commented Dec 17, 2021

I could create a READMEHEADER.md in the style of ADOPTERS.md, the substitution will take care of the project related links and the others are just the same everywhere.
Then add a line to sync.sh and

<!--BEGIN READMEHEADER-->
<!--END READMEHEADER-->

in every README.
That should do the trick.
Then we can easily add dockertest and others later on.
Wdyt?

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #2074 (48e5a16) into master (406d3f4) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 48e5a16 differs from pull request most recent head 3a0ece5. Consider uploading reports for the commit 3a0ece5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
+ Coverage   74.93%   74.94%   +0.01%     
==========================================
  Files         293      293              
  Lines       15318    15318              
==========================================
+ Hits        11478    11480       +2     
+ Misses       3012     3011       -1     
+ Partials      828      827       -1     
Impacted Files Coverage Δ
internal/testhelpers/e2e_server.go 89.56% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406d3f4...3a0ece5. Read the comment docs.

@aeneasr
Copy link
Member

aeneasr commented Dec 17, 2021

SGTM!

@aeneasr
Copy link
Member

aeneasr commented Dec 17, 2021

We can merge this anyways, please add the badge to the other repos as well :)

@vinckr
Copy link
Member Author

vinckr commented Dec 17, 2021

Ok :)

README.md Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Dec 17, 2021

I updated the description a bit

@aeneasr aeneasr merged commit 0c1e816 into ory:master Dec 17, 2021
@vinckr vinckr deleted the readme-vinckr branch January 7, 2022 12:22
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants