-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change SQLite database mode to 0600 #2344
Conversation
The default mode is 0644, which is allows broader access than necessary.
Codecov Report
@@ Coverage Diff @@
## master #2344 +/- ##
==========================================
+ Coverage 76.39% 76.61% +0.22%
==========================================
Files 318 318
Lines 17370 17189 -181
==========================================
- Hits 13269 13170 -99
+ Misses 3162 3087 -75
+ Partials 939 932 -7
Continue to review full report at Codecov.
|
The default mode is 0644, which is allows broader access than necessary.
I guess we should carry these changes over to Hydra and Keto as well? |
Hello @drigz |
The default mode is 0644, which is allows broader access than necessary.
The default mode is 0644, which is allows broader access than necessary.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
I haven't added an automated test, as I didn't see a clean place to add it (maybe
test/e2e/run.sh
but there are no assertions there, and Cypress seems more about asserting what happens in the browser. If I should add a test, let me know where.Instead, here's "proof" that it works: