Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(courier): add ability to specify backoff #2349

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Mar 29, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner March 29, 2022 09:23
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #2349 (0e2ecd5) into master (852f24f) will decrease coverage by 0.00%.
The diff coverage is 40.00%.

❗ Current head 0e2ecd5 differs from pull request most recent head f93ba6f. Consider uploading reports for the commit f93ba6f to get more accurate results

@@            Coverage Diff             @@
##           master    #2349      +/-   ##
==========================================
- Coverage   76.56%   76.56%   -0.01%     
==========================================
  Files         318      318              
  Lines       17294    17298       +4     
==========================================
+ Hits        13242    13244       +2     
- Misses       3119     3121       +2     
  Partials      933      933              
Impacted Files Coverage Δ
courier/courier.go 73.33% <40.00%> (-3.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d950320...f93ba6f. Read the comment docs.

@aeneasr aeneasr merged commit bf970f3 into master Mar 29, 2022
@aeneasr aeneasr deleted the fix-backoff-courier branch March 29, 2022 10:21
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant