Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove required legacy field #2410

Merged
merged 1 commit into from
Apr 20, 2022
Merged

fix: remove required legacy field #2410

merged 1 commit into from
Apr 20, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Apr 20, 2022

Closes #2408

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner April 20, 2022 00:49
@aeneasr aeneasr self-assigned this Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #2410 (a40ed32) into master (a42a0f7) will not change coverage.
The diff coverage is 0.00%.

❗ Current head a40ed32 differs from pull request most recent head 270cb73. Consider uploading reports for the commit 270cb73 to get more accurate results

@@           Coverage Diff           @@
##           master    #2410   +/-   ##
=======================================
  Coverage   76.62%   76.62%           
=======================================
  Files         315      315           
  Lines       17358    17358           
=======================================
  Hits        13300    13300           
  Misses       3122     3122           
  Partials      936      936           
Impacted Files Coverage Δ
selfservice/strategy/oidc/provider_config.go 37.20% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f87bca...270cb73. Read the comment docs.

@aeneasr aeneasr merged commit 638d45c into master Apr 20, 2022
@aeneasr aeneasr deleted the fix-2408 branch April 20, 2022 17:20
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant