Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOCKED - fix: use predictable SQLite in memory DSNs #2415

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Apr 22, 2022

Closes #2059

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner April 22, 2022 00:05
@aeneasr aeneasr changed the title fix: use predictable SQLite in memory DSNs BLOCKED - fix: use predictable SQLite in memory DSNs Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2415 (e2112df) into master (7165fa0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e2112df differs from pull request most recent head 7ecc440. Consider uploading reports for the commit 7ecc440 to get more accurate results

@@           Coverage Diff           @@
##           master    #2415   +/-   ##
=======================================
  Coverage   76.43%   76.43%           
=======================================
  Files         316      316           
  Lines       17438    17438           
=======================================
  Hits        13329    13329           
- Misses       3173     3174    +1     
+ Partials      936      935    -1     
Impacted Files Coverage Δ
driver/config/config.go 81.87% <ø> (ø)
driver/registry_default.go 86.33% <100.00%> (ø)
internal/driver.go 100.00% <100.00%> (ø)
session/test/persistence.go 98.61% <0.00%> (-1.39%) ⬇️
persistence/sql/persister_courier.go 91.66% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7165fa0...7ecc440. Read the comment docs.

@aeneasr aeneasr merged commit 51a13f7 into master Apr 29, 2022
@aeneasr aeneasr deleted the fix-2059 branch April 29, 2022 14:07
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sqlite tables disappear?
1 participant