Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pointer of string for PasswordIdentifier in example code #2421

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

johejo
Copy link
Contributor

@johejo johejo commented Apr 24, 2022

Related issue(s)

db638cd

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2421 (f58378e) into master (638d45c) will decrease coverage by 0.01%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master    #2421      +/-   ##
==========================================
- Coverage   76.39%   76.38%   -0.02%     
==========================================
  Files         316      316              
  Lines       17404    17431      +27     
==========================================
+ Hits        13296    13314      +18     
- Misses       3171     3181      +10     
+ Partials      937      936       -1     
Impacted Files Coverage Δ
selfservice/strategy/oidc/provider_discord.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_facebook.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_github.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_github_app.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_microsoft.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_netid.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_slack.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_spotify.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_vk.go 0.00% <0.00%> (ø)
selfservice/strategy/oidc/provider_yandex.go 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a90c8...f58378e. Read the comment docs.

@aeneasr aeneasr merged commit 61f12e7 into ory:master Apr 24, 2022
@vinckr
Copy link
Member

vinckr commented Apr 26, 2022

Hello @johejo
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants