Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openapi regression #2465

Merged
merged 2 commits into from
May 13, 2022
Merged

fix: openapi regression #2465

merged 2 commits into from
May 13, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented May 13, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner May 13, 2022 13:49
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea to make the node type on the specific attributes string, but keep the enum as the discriminator?

@aeneasr
Copy link
Member Author

aeneasr commented May 13, 2022

Exactly - because the target of the discriminator is not an enum, it's always the same value (otherwise it would be a different type). I think that trips out the generator

@aeneasr aeneasr merged commit 37a3369 into master May 13, 2022
@aeneasr aeneasr deleted the fix-nodes branch May 13, 2022 15:21
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants