Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add flow id when return_to is passed to the verification #2482

Conversation

jhonatanhulse
Copy link
Contributor

@jhonatanhulse jhonatanhulse commented May 20, 2022

This pull request basically appends the flow ID when redirecting the user to the passed return_to URL after clicking the verification link.

Related issue(s)

#2481

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented May 20, 2022

CLA assistant check
All committers have signed the CLA.

@jhonatanhulse jhonatanhulse force-pushed the fix/when-return_to-is-passed-to-the-verification-flow-the-redirection-does-not-append-the-flow-id branch from 2efdcbe to bd4eb4b Compare May 23, 2022 17:48
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #2482 (8e37eb6) into master (29e4a51) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2482      +/-   ##
==========================================
+ Coverage   76.50%   76.53%   +0.02%     
==========================================
  Files         317      317              
  Lines       17642    17644       +2     
==========================================
+ Hits        13497    13503       +6     
+ Misses       3209     3205       -4     
  Partials      936      936              
Impacted Files Coverage Δ
selfservice/flow/verification/flow.go 90.36% <100.00%> (+0.23%) ⬆️
selfservice/strategy/link/strategy_verification.go 56.44% <100.00%> (ø)
cmd/courier/watch.go 76.27% <0.00%> (+6.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083e67f...8e37eb6. Read the comment docs.

@jhonatanhulse jhonatanhulse force-pushed the fix/when-return_to-is-passed-to-the-verification-flow-the-redirection-does-not-append-the-flow-id branch from bd4eb4b to 8e37eb6 Compare May 23, 2022 18:26
@aeneasr aeneasr merged commit c2b1c23 into ory:master May 23, 2022
@jhonatanhulse jhonatanhulse deleted the fix/when-return_to-is-passed-to-the-verification-flow-the-redirection-does-not-append-the-flow-id branch May 23, 2022 21:20
@vinckr
Copy link
Member

vinckr commented May 24, 2022

Hello @jhullse
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants