Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth0): created_at workaround #2492

Merged
merged 1 commit into from
May 27, 2022
Merged

fix(auth0): created_at workaround #2492

merged 1 commit into from
May 27, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented May 27, 2022

Closes #2485

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner May 27, 2022 19:06
@aeneasr aeneasr self-assigned this May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #2492 (cc228b4) into master (9717762) will increase coverage by 0.08%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master    #2492      +/-   ##
==========================================
+ Coverage   76.50%   76.59%   +0.08%     
==========================================
  Files         317      317              
  Lines       17644    17636       -8     
==========================================
+ Hits        13499    13508       +9     
+ Misses       3208     3190      -18     
- Partials      937      938       +1     
Impacted Files Coverage Δ
selfservice/strategy/oidc/provider_auth0.go 63.49% <41.66%> (+14.19%) ⬆️
session/test/persistence.go 100.00% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617949c...cc228b4. Read the comment docs.

@aeneasr aeneasr merged commit 52a965d into master May 27, 2022
@aeneasr aeneasr deleted the close-2485 branch May 27, 2022 21:27
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to sign in with Auth0
1 participant