fix: remove newline sign from email subject

[mszekiel]

Removed empty lines in email.subject.gotmpl and removed .trim() in tests, which prevented from spotting that bug.

Related issue(s)

Fixes #2491

Checklist

• I have read the contributing guidelines.
• I have referenced an issue containing the design document if my change introduces a new feature.
• I am following the contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security vulnerability.
  If this pull request addresses a security. vulnerability,
  I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
• I have added tests that prove my fix is effective or that my feature works.
• I have added or changed the documentation.

Further Comments

I also considered that we could use the trim() in EmailSubject/LoadText functions, but then also the same is being used for body, so not sure if this could break more. For now, this PR is the simplest solution.

[zepatrik]

Good catch 👍

I would suggest that we rather trim all subjects in the EmailSubject functions, because this is something users (and tools) might get wrong regularly (e.g. prettier ensures files end with a newline).

[codecov]

Codecov Report

Merging #2576 (ba41384) into master (c058e23) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ba41384 differs from pull request most recent head 627ee4c. Consider uploading reports for the commit 627ee4c to get more accurate results

@@            Coverage Diff             @@
##           master    #2576      +/-   ##
==========================================
+ Coverage   76.59%   76.62%   +0.02%     
==========================================
  Files         321      321              
  Lines       17961    17961              
==========================================
+ Hits        13758    13762       +4     
+ Misses       3252     3249       -3     
+ Partials      951      950       -1     

Impacted Files	Coverage Δ
persistence/sql/persister_courier.go	89.70% <0.00%> (ø)
session/test/persistence.go	100.00% <0.00%> (+1.38%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e746c33...627ee4c. Read the comment docs.

[aeneasr]

Awesome, thank you! 🎉 Your contribution makes Ory better :)

[vinckr]

Hello @mszekiel
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!