Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix debugging Docker setup #2616

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: Fix debugging Docker setup #2616

merged 1 commit into from
Jul 25, 2022

Conversation

t-tomalak
Copy link
Contributor

The new go version needs some tweaks in our debugging setup.

  • Disabling -buildvcs=false in go build, this is a new "feature" introduced in go 1.18 but is not required for working binary and if turned on can throw errors on incompatible versions of git
  • RUN go get github.com/go-delve/delve/cmd/dlv doesn't work on the new version and instead is recommended to use go install with the specified version

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security. vulnerability,
    I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

New go version, needs some tweaks in our debugging setup.
* Disabling `-buildvcs=false` in go build, this is new "feature" introduced in go 1.18 but is not required for working binary and if turned on can throw errors on incompatible versions of git
* `RUN go get github.com/go-delve/delve/cmd/dlv` doesn't work on new version and instead is recommended to use go install with specified version
@t-tomalak t-tomalak changed the title Fix debugging Docker setup fix: Fix debugging Docker setup Jul 25, 2022
@aeneasr aeneasr merged commit aaabe75 into ory:master Jul 25, 2022
@t-tomalak t-tomalak deleted the fix-debug-setup branch July 25, 2022 12:37
@vinckr
Copy link
Member

vinckr commented Jul 26, 2022

Hello @t-tomalak
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants