Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing docker dependencies #2643

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

sayoun
Copy link
Contributor

@sayoun sayoun commented Aug 5, 2022

add missing dependencies for docker build, without them the make docker command will fail with the following error

 => ERROR [base 9/9] RUN --mount=type=cache,target=/root/.cache/go-build go build -tags sqlite     -ldflags="-X 'github.com/ory/kratos/driver/config.Version=${VERSION}' -X 'github.com/ory/kratos/driver/config.Date=2022-08-05T08  0.8s
------
 > [base 9/9] RUN --mount=type=cache,target=/root/.cache/go-build go build -tags sqlite     -ldflags="-X 'github.com/ory/kratos/driver/config.Version=${VERSION}' -X 'github.com/ory/kratos/driver/config.Date=2022-08-05T08:57:33Z' -X 'github.com/ory/kratos/driver/config.Commit=8fa14ecb41aa08f9d532439cf5d50bcd8fc5f55f'"     -o /usr/bin/kratos:
#18 0.746 # github.com/mattn/go-sqlite3
#18 0.746 cgo: C compiler "gcc" not found: exec: "gcc": executable file not found in $PATH
------
executor failed running [/bin/sh -c go build -tags sqlite     -ldflags="-X 'github.com/ory/kratos/driver/config.Version=${VERSION}' -X 'github.com/ory/kratos/driver/config.Date=${BUILD_DATE}' -X 'github.com/ory/kratos/driver/config.Commit=${COMMIT}'"     -o /usr/bin/kratos]: exit code: 2
make: *** [Makefile:143: docker] Error 1

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security. vulnerability,
    I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

@sayoun sayoun changed the title fix(docker): add missing dependencies fix: add missing docker dependencies Aug 5, 2022
@aeneasr
Copy link
Member

aeneasr commented Aug 5, 2022

👍

@aeneasr aeneasr merged commit c589520 into ory:master Aug 5, 2022
@sayoun sayoun deleted the fix_docker_build branch August 5, 2022 09:21
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants