-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include flow id in use recovery token query #2679
Merged
aeneasr
merged 8 commits into
ory:master
from
jonas-jonas:fix/connectFlowIdToRecoveryToken
Aug 25, 2022
Merged
fix: include flow id in use recovery token query #2679
aeneasr
merged 8 commits into
ory:master
from
jonas-jonas:fix/connectFlowIdToRecoveryToken
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
commented
Aug 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #2679 +/- ##
=======================================
Coverage 75.14% 75.14%
=======================================
Files 293 293
Lines 16740 16740
=======================================
Hits 12580 12580
Misses 3196 3196
Partials 964 964
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aeneasr
requested changes
Aug 24, 2022
...grations/sql/20220819132309000000_add_flow_type_to_identity_recovery_tokens.cockroach.up.sql
Outdated
Show resolved
Hide resolved
aeneasr
reviewed
Aug 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just one question then we're ✅
aeneasr
approved these changes
Aug 25, 2022
7 tasks
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
This PR adds the `selfservice_recovery_flow_id` to the query used when "using" a token in the recovery flow. This PR also adds a new enum field for `identity_recovery_tokens` to distinguish the two flows: admin versus self-service recovery. BREAKING CHANGES: This patch invalidates recovery flows initiated using the Admin API. Please re-generate any admin-generated recovery flows and tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
selfservice_recovery_flow_id
to the query used when "using" a token in the recovery flow.This PR also adds a new enum field for
identity_recovery_tokens
to distinguish the two flows: admin versus self-service recovery.BREAKING CHANGES: This patch invalidates recovery flows initiated using the Admin API. Please re-generate any admin-generated recovery flows and tokens.