fix: express e2e tests

[Benehiko]

Related issue(s)

Checklist

• I have read the contributing guidelines.
• I have referenced an issue containing the design document if my change introduces a new feature.
• I am following the contributing code guidelines.
• I have read the security policy.
• I confirm that this pull request does not address a security vulnerability.
  If this pull request addresses a security. vulnerability,
  I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
• I have added tests that prove my fix is effective or that my feature works.
• I have added or changed the documentation.

Further Comments

[codecov]

Codecov Report

Merging #2708 (d8514b5) into master (d8514b5) will not change coverage.
The diff coverage is n/a.

❗ Current head d8514b5 differs from pull request most recent head 26bbb99. Consider uploading reports for the commit 26bbb99 to get more accurate results

@@           Coverage Diff           @@
##           master    #2708   +/-   ##
=======================================
  Coverage   75.81%   75.81%           
=======================================
  Files         302      302           
  Lines       17784    17784           
=======================================
  Hits        13483    13483           
  Misses       3270     3270           
  Partials     1031     1031           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[jonas-jonas]

Looks good! Just minor things.

We should also try to get rid of the app === 'express' checks again. Do we have plans to bring the new Managed UI to mobile as well?

[Benehiko]

Looks good! Just minor things.

We should also try to get rid of the app === 'express' checks again. Do we have plans to bring the new Managed UI to mobile as well?

Yeah it is a bit of a mess in here. That's why I will create a nice e2e testing library inside elements to have a standard across stacks (express, react, react-native etc).

Right now this was added initially to reduce flakes since @aeneasr wanted to make sure the correct app was run in the test. That is also why we add a selector to the application on the body or parent container.

https://github.com/ory/kratos-selfservice-ui-node/pull/189/files#diff-a2e0bd2454eead56ab21f734d4c6ac807de3dd1d6e05fd4e0917125533d07030R15

[jonas-jonas]

I think you need to update the ory-prettier-styles package by running npm i in the root. Other than that, LGTM.

[Benehiko]

Found some failing tests while updating the express app. Will need to fix them first before this can be merged.