Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing cookie headers to SDK methods #2720

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Sep 8, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security. vulnerability,
    I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr changed the title Add settings cookie token feat: add missing cookie headers to SDK methods Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #2720 (9f70baf) into master (3e3b59e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2720      +/-   ##
==========================================
+ Coverage   75.11%   75.14%   +0.02%     
==========================================
  Files         293      293              
  Lines       16908    16908              
==========================================
+ Hits        12701    12705       +4     
+ Misses       3235     3232       -3     
+ Partials      972      971       -1     
Impacted Files Coverage Δ
selfservice/flow/login/handler.go 78.40% <ø> (ø)
selfservice/flow/settings/handler.go 68.00% <ø> (ø)
session/test/persistence.go 100.00% <0.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 32e32d1 into master Sep 12, 2022
@aeneasr aeneasr deleted the add-settings-cookie-token branch September 12, 2022 06:39
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant