Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch invalidates credentials #2721

Merged
merged 3 commits into from
Sep 11, 2022
Merged

fix: patch invalidates credentials #2721

merged 3 commits into from
Sep 11, 2022

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Fixes ory/network#148

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I am following the contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security. vulnerability,
    I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #2721 (cdf17b6) into master (1689bb9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2721      +/-   ##
==========================================
+ Coverage   75.16%   75.19%   +0.02%     
==========================================
  Files         293      293              
  Lines       16798    16800       +2     
==========================================
+ Hits        12626    12632       +6     
+ Misses       3203     3200       -3     
+ Partials      969      968       -1     
Impacted Files Coverage Δ
identity/handler.go 87.73% <100.00%> (+0.15%) ⬆️
session/test/persistence.go 100.00% <0.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonas-jonas jonas-jonas marked this pull request as ready for review September 9, 2022 09:39
identity/handler.go Outdated Show resolved Hide resolved
@aeneasr aeneasr merged commit c4d95af into ory:master Sep 11, 2022
@jonas-jonas jonas-jonas deleted the fix/patchInvalidatesCredentials branch September 12, 2022 06:58
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identity breaks after metadata change via API
2 participants