fix: format check stage in the CI #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Sep 16, 2022
| @@ -83,8 +83,6 @@ jobs: | |||
| uses: sonatype-nexus-community/nancy-github-action@v1.0.2 | |||
| - run: npm install | |||
| name: Install node deps | |||
| - name: Run prettier | |||
There was a problem hiding this comment.
Is the formatting now checked somewhere else?
There was a problem hiding this comment.
There was a problem hiding this comment.
We can also rollback 20fdfe8 if the format check needs to be kept as a pre-req for tests
There was a problem hiding this comment.
Take a look now please
Codecov Report
@@ Coverage Diff @@
## master #2737 +/- ##
==========================================
+ Coverage 75.15% 75.19% +0.04%
==========================================
Files 294 294
Lines 17068 17068
==========================================
+ Hits 12828 12835 +7
+ Misses 3264 3258 -6
+ Partials 976 975 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kelkarajay
force-pushed
the
fix/format-stage
branch
from
ac46cb9
to
ed305a0
Compare
aeneasr
previously approved these changes
Sep 16, 2022
kelkarajay
changed the title
kelkarajay
changed the title
aeneasr
approved these changes
Sep 16, 2022
7 tasks
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CI workflow. The format checks had been moved to an independent workflow (https://github.com/ory/kratos/blob/master/.github/workflows/format.yml) to be triggered for PR's and master builds.
Related issue(s)
Build failure on master
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments