Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2711 include metadata_admin in admin identity list response #2791

Conversation

brahmlower
Copy link
Contributor

@brahmlower brahmlower commented Oct 9, 2022

The admin identities list response now includes metadata_admin property within the returned identities.

Related issue(s)

#2711

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.
    (n/a: This fix makes the implementation compliant with existing docs)

Further Comments

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #2791 (a8feade) into master (8043371) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2791      +/-   ##
==========================================
- Coverage   75.81%   75.81%   -0.01%     
==========================================
  Files         302      302              
  Lines       17777    17784       +7     
==========================================
+ Hits        13478    13483       +5     
- Misses       3269     3270       +1     
- Partials     1030     1031       +1     
Impacted Files Coverage Δ
identity/handler.go 87.95% <100.00%> (+0.22%) ⬆️
identity/identity.go 89.94% <100.00%> (+0.22%) ⬆️
persistence/sql/persister_courier.go 82.82% <0.00%> (-2.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brahmlower
Copy link
Contributor Author

I'm not sure if there's anything I can do about that failing test for product board synchronization? If there's anything needed of me for that, just let me know 😁

@aeneasr
Copy link
Member

aeneasr commented Oct 11, 2022

Great fix, thank you!

@aeneasr aeneasr merged commit aa698e0 into ory:master Oct 11, 2022
@brahmlower brahmlower deleted the fix/2711-admin-identity-list-includes-metadata_admin branch October 11, 2022 15:30
@vinckr
Copy link
Member

vinckr commented Oct 12, 2022

Hello @brahmlower
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants