Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove skip network init option parameter #3066

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

kelkarajay
Copy link
Contributor

@kelkarajay kelkarajay commented Feb 3, 2023

Remove the option parameter that prevents network init. The delete queries cannot handle nil values for nid.

@kelkarajay kelkarajay changed the title fix: remove network omit flag fix: remove skip network init flag Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #3066 (b272e1a) into master (44556a4) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head b272e1a differs from pull request most recent head 3f172b2. Consider uploading reports for the commit 3f172b2 to get more accurate results

@@            Coverage Diff             @@
##           master    #3066      +/-   ##
==========================================
+ Coverage   77.28%   77.34%   +0.06%     
==========================================
  Files         313      313              
  Lines       19552    19552              
==========================================
+ Hits        15110    15122      +12     
+ Misses       3274     3264      -10     
+ Partials     1168     1166       -2     
Impacted Files Coverage Δ
cmd/cliclient/cleanup.go 27.27% <0.00%> (ø)
session/test/persistence.go 99.05% <0.00%> (-0.95%) ⬇️
persistence/sql/persister_courier.go 86.50% <0.00%> (+3.17%) ⬆️
courier/courier_dispatcher.go 59.21% <0.00%> (+15.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kelkarajay kelkarajay linked an issue Feb 3, 2023 that may be closed by this pull request
6 tasks
@kelkarajay kelkarajay self-assigned this Feb 3, 2023
@kelkarajay kelkarajay changed the title fix: remove skip network init flag fix: remove skip network init option parameter Feb 3, 2023
@kelkarajay kelkarajay marked this pull request as ready for review February 3, 2023 09:57
@aeneasr aeneasr merged commit c629b72 into master Feb 3, 2023
@aeneasr aeneasr deleted the fix/cmd-panic branch February 3, 2023 10:07
splaunov pushed a commit to monta-app/kratos that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup sql panic: nid must be not nil
2 participants