Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the query parameter name in the get self-service error endpoint in API docs #308

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

sandhose
Copy link
Contributor

Related issue

None

Proposed changes

The query parameter for the self-service errors endpoint was named id in the API docs, whereas it is the error param that is used by the handler.

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

I regenerated the SDK

The query parameter for the self-service errors endpoint was named `id`
in the API docs, whereas it is the `error` param that is used by the
handler.
@aeneasr
Copy link
Member

aeneasr commented Mar 25, 2020

Thank you!

@aeneasr aeneasr merged commit be257f5 into ory:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants