Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly apply patches to identity metadata #3103

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Fixes #2950

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas

This comment was marked as outdated.


t.Run("case=should delete a user and no longer be able to retrieve it", func(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved a few tests around, as they weren't in the right sub-test anyway. Probably best to review without whitespace changes.

@jonas-jonas jonas-jonas self-assigned this Feb 14, 2023
@jonas-jonas jonas-jonas marked this pull request as ready for review February 14, 2023 15:56
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #3103 (b76a5f4) into master (1a5ead4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b76a5f4 differs from pull request most recent head 6372639. Consider uploading reports for the commit 6372639 to get more accurate results

@@           Coverage Diff           @@
##           master    #3103   +/-   ##
=======================================
  Coverage   77.42%   77.43%           
=======================================
  Files         315      315           
  Lines       19844    19858   +14     
=======================================
+ Hits        15365    15377   +12     
- Misses       3289     3291    +2     
  Partials     1190     1190           
Impacted Files Coverage Δ
identity/handler.go 85.47% <100.00%> (+0.89%) ⬆️
courier/message.go 71.73% <0.00%> (-2.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 1193a56 into master Feb 15, 2023
@aeneasr aeneasr deleted the jonas-jonas/fix/patchMetadata branch February 15, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't update metadata with patch
2 participants