Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add HydraLoginRequest on flow creation #3152

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

CaptainStandby
Copy link
Contributor

@CaptainStandby CaptainStandby commented Mar 7, 2023

fixes #3108

The oauth2_login_request field was missing when initially creating the login flow.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CaptainStandby CaptainStandby marked this pull request as ready for review March 7, 2023 17:18
@CaptainStandby CaptainStandby self-assigned this Mar 7, 2023
@aeneasr
Copy link
Member

aeneasr commented Mar 8, 2023

Can you explain what this fixes?

@CaptainStandby
Copy link
Contributor Author

Can you explain what this fixes?

Forgot to add the ticket yesterday 🙈
This fixes this issue #3108 where the oauth2_login_request field was missing on initial flow creation.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #3152 (a1244b9) into master (dba3803) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a1244b9 differs from pull request most recent head e2b2b7f. Consider uploading reports for the commit e2b2b7f to get more accurate results

@@            Coverage Diff             @@
##           master    #3152      +/-   ##
==========================================
- Coverage   77.58%   77.57%   -0.01%     
==========================================
  Files         316      316              
  Lines       19906    19907       +1     
==========================================
- Hits        15444    15443       -1     
- Misses       3273     3274       +1     
- Partials     1189     1190       +1     
Impacted Files Coverage Δ
selfservice/flow/login/handler.go 78.87% <100.00%> (+0.09%) ⬆️
session/test/persistence.go 99.05% <0.00%> (-0.95%) ⬇️
courier/message.go 73.91% <0.00%> (+2.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Registration has the same problem by the way.

@aeneasr aeneasr merged commit 09312dd into master Mar 8, 2023
@aeneasr aeneasr deleted the hf/Hydra_+_Kratos_login_flow branch March 8, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra + Kratos login flow
2 participants