fix: do not omit last page on identity list #3169
Conversation
| @@ -180,7 +180,7 @@ func (h *Handler) list(w http.ResponseWriter, r *http.Request, _ httprouter.Para | |||
| isam[i] = WithCredentialsMetadataAndAdminMetadataInJSON(identity) | |||
| } | |||
|
|
|||
| migrationpagination.PaginationHeader(w, urlx.AppendPaths(h.r.Config().SelfAdminURL(r.Context()), RouteCollection), total, page, itemsPerPage) | |||
| migrationpagination.PaginationHeader(w, urlx.AppendPaths(h.r.Config().SelfAdminURL(r.Context()), RouteCollection), total+int64(itemsPerPage), page, itemsPerPage) | |||
There was a problem hiding this comment.
This is a super ugly hack, please suggest a better way if you know any. page-1 does not work because then we get 1 as the next page for 1.
There was a problem hiding this comment.
Why is this necessary? Doesn't that value come from the DB?
Ah, nvm.
There was a problem hiding this comment.
This breaks the x-total-count unfortunately.
Codecov Report
@@ Coverage Diff @@
## master #3169 +/- ##
==========================================
- Coverage 77.71% 77.62% -0.09%
==========================================
Files 317 317
Lines 20036 20036
==========================================
- Hits 15571 15553 -18
- Misses 3277 3291 +14
- Partials 1188 1192 +4
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The problem is that the persister uses
1as the fist page, while the pagination header helper assumes0is the first page. Therefore, until now, the second-last page was considered the last and nonextrel was set in theLinkheader.This is the only way I could think of to make this not a breaking change, but it is super ugly.