Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account settings broken on OIDC removal #3185

Merged
merged 3 commits into from
Mar 26, 2023

Conversation

CaptainStandby
Copy link
Contributor

@CaptainStandby CaptainStandby commented Mar 23, 2023

Related issue(s)

ory-corp/cloud#3514

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CaptainStandby CaptainStandby changed the title fix: Account Settings Broken on OIDC removal fix: account settings broken on OIDC removal Mar 23, 2023
@CaptainStandby CaptainStandby force-pushed the hf/broken_settings_on_oidc_removal branch from fbf5490 to f97913d Compare March 23, 2023 13:58
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #3185 (5355862) into master (eb854be) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 5355862 differs from pull request most recent head aa05fd6. Consider uploading reports for the commit aa05fd6 to get more accurate results

@@           Coverage Diff           @@
##           master    #3185   +/-   ##
=======================================
  Coverage   77.64%   77.65%           
=======================================
  Files         319      319           
  Lines       20110    20116    +6     
=======================================
+ Hits        15615    15621    +6     
  Misses       3298     3298           
  Partials     1197     1197           
Impacted Files Coverage Δ
selfservice/strategy/oidc/strategy_settings.go 63.09% <46.66%> (-0.68%) ⬇️
identity/handler.go 85.77% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CaptainStandby CaptainStandby force-pushed the hf/broken_settings_on_oidc_removal branch from 616b269 to 7cba149 Compare March 23, 2023 19:44
@CaptainStandby CaptainStandby force-pushed the hf/broken_settings_on_oidc_removal branch from 7cba149 to 5748b1c Compare March 23, 2023 19:45
@CaptainStandby CaptainStandby self-assigned this Mar 23, 2023
@CaptainStandby CaptainStandby marked this pull request as ready for review March 23, 2023 19:48
Comment on lines +65 to +68
--cleanup)
cleanup=yes
shift # past argument=value
;;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this so I could manually trigger a cleanup, because there were often services left running in the background, which caused problems for me (ports in use, etc.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aeneasr aeneasr merged commit 61ae531 into master Mar 26, 2023
@aeneasr aeneasr deleted the hf/broken_settings_on_oidc_removal branch March 26, 2023 10:18
@kszafran
Copy link
Contributor

kszafran commented Apr 18, 2023

@CaptainStandby When referencing issues from ory-corp, it would be great if you could copy the description of the issue or summarize it. Mortals like me don't have access to ory-corp issues. I found this fix mentioned in the release notes, and I'd like to know what bug is there in the Kratos version that I'm currently running.

@CaptainStandby
Copy link
Contributor Author

Sure, I can provide an excerpt:

The account settings page is broken when the user used an OIDC provider which is now removed, but only if the project still has an active OIDC provider.

To Reproduce

  1. Link an OIDC provider to the project
  2. Create an account with said OIDC provider
  3. Set a password for the account
  4. Remove OIDC provider from project
  5. Add another OIDC provider (e.g. discord)
  6. Sign into the account using the password
  7. Go to account settings page.

There will be an error describing

OpenID Connect Provider '\github\` is unknown or has not been configured

@kszafran
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants