-
-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: account settings broken on OIDC removal #3185
Conversation
fbf5490
to
f97913d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3185 +/- ##
=======================================
Coverage 77.64% 77.65%
=======================================
Files 319 319
Lines 20110 20116 +6
=======================================
+ Hits 15615 15621 +6
Misses 3298 3298
Partials 1197 1197
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
616b269
to
7cba149
Compare
7cba149
to
5748b1c
Compare
...egy-suite=unlink-case=should_not_be_able_to_unlink_an_non-existing_connection-flow=json.json
Show resolved
Hide resolved
...gy-suite=unlink-case=should_not_be_able_to_unlink_an_non-existing_connection-flow=fetch.json
Show resolved
Hide resolved
...egy-suite=unlink-case=should_not_be_able_to_unlink_an_non-existing_connection-flow=json.json
Show resolved
Hide resolved
...gy-suite=unlink-case=should_not_be_able_to_unlink_an_non-existing_connection-flow=fetch.json
Show resolved
Hide resolved
--cleanup) | ||
cleanup=yes | ||
shift # past argument=value | ||
;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this so I could manually trigger a cleanup, because there were often services left running in the background, which caused problems for me (ports in use, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@CaptainStandby When referencing issues from ory-corp, it would be great if you could copy the description of the issue or summarize it. Mortals like me don't have access to ory-corp issues. I found this fix mentioned in the release notes, and I'd like to know what bug is there in the Kratos version that I'm currently running. |
Sure, I can provide an excerpt:
|
Thank you! |
Related issue(s)
ory-corp/cloud#3514
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments