Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing code discriminator in updateVerificationFlow #3213

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Fixes ory/sdk#260

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #3213 (a820a9d) into master (03ef8bf) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a820a9d differs from pull request most recent head 1779684. Consider uploading reports for the commit 1779684 to get more accurate results

@@           Coverage Diff           @@
##           master    #3213   +/-   ##
=======================================
  Coverage   77.94%   77.94%           
=======================================
  Files         320      320           
  Lines       20430    20430           
=======================================
  Hits        15924    15924           
  Misses       3303     3303           
  Partials     1203     1203           
Impacted Files Coverage Δ
selfservice/strategy/code/strategy_verification.go 74.25% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 21576be into master Apr 5, 2023
@aeneasr aeneasr deleted the jonas-jonas/addMissingVerificationCodeAnnotation branch April 5, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema does not define code method for verification
2 participants