Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept OIDC login request in browser+JSON login flow #3271

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented May 9, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this May 9, 2023
@hperl hperl marked this pull request as ready for review May 9, 2023 10:42
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3271 (1b09509) into master (22e8daf) will decrease coverage by 0.01%.
The diff coverage is 94.11%.

❗ Current head 1b09509 differs from pull request most recent head a44dfca. Consider uploading reports for the commit a44dfca to get more accurate results

@@            Coverage Diff             @@
##           master    #3271      +/-   ##
==========================================
- Coverage   78.13%   78.12%   -0.01%     
==========================================
  Files         325      325              
  Lines       21102    21079      -23     
==========================================
- Hits        16487    16468      -19     
+ Misses       3387     3383       -4     
  Partials     1228     1228              
Impacted Files Coverage Δ
hydra/fake.go 70.00% <88.88%> (+25.55%) ⬆️
selfservice/flow/login/hook.go 86.23% <100.00%> (+0.62%) ⬆️
selfservice/strategy/oidc/strategy_login.go 67.05% <100.00%> (ø)

... and 1 file with indirect coverage changes

selfservice/flow/login/hook.go Outdated Show resolved Hide resolved
@hperl hperl marked this pull request as draft May 25, 2023 07:58
@hperl hperl force-pushed the hperl/fix-oidc-browser-json-login branch from 5f5d619 to 2ff355e Compare June 13, 2023 08:32
@hperl hperl marked this pull request as ready for review June 13, 2023 10:20
@hperl hperl force-pushed the hperl/fix-oidc-browser-json-login branch 2 times, most recently from ff2a0de to 940e9b0 Compare June 13, 2023 10:58
@hperl hperl requested a review from jonas-jonas June 13, 2023 14:59
@hperl hperl force-pushed the hperl/fix-oidc-browser-json-login branch from c5a5972 to 93bb1c1 Compare June 15, 2023 08:56
@hperl hperl force-pushed the hperl/fix-oidc-browser-json-login branch from 93bb1c1 to a44dfca Compare June 15, 2023 12:31
@hperl hperl merged commit ad54093 into master Jun 15, 2023
26 checks passed
@hperl hperl deleted the hperl/fix-oidc-browser-json-login branch June 15, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants