Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: identity list pagination #3325

Merged
merged 3 commits into from
Jun 19, 2023
Merged

fix: identity list pagination #3325

merged 3 commits into from
Jun 19, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 19, 2023

Resolves a pesky issue that would skip the last page.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Resolves a pesky issue that would skip the last page.
@aeneasr aeneasr requested a review from zepatrik as a code owner June 19, 2023 10:22
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #3325 (fe48534) into master (3485204) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head fe48534 differs from pull request most recent head 9ea1e64. Consider uploading reports for the commit 9ea1e64 to get more accurate results

@@            Coverage Diff             @@
##           master    #3325      +/-   ##
==========================================
- Coverage   78.20%   78.12%   -0.08%     
==========================================
  Files         325      325              
  Lines       21079    21079              
==========================================
- Hits        16484    16468      -16     
- Misses       3370     3383      +13     
- Partials     1225     1228       +3     
Impacted Files Coverage Δ
persistence/sql/identity/persister_identity.go 80.03% <100.00%> (ø)

... and 2 files with indirect coverage changes

@aeneasr aeneasr merged commit 9d3ef0d into master Jun 19, 2023
26 checks passed
@aeneasr aeneasr deleted the fix-pagination branch June 19, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant