Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect override in identity hydrate #3368

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jul 6, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr requested a review from zepatrik as a code owner July 6, 2023 09:37
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #3368 (cfe7a0e) into master (8f9bff5) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

❗ Current head cfe7a0e differs from pull request most recent head ae7863e. Consider uploading reports for the commit ae7863e to get more accurate results

@@            Coverage Diff             @@
##           master    #3368      +/-   ##
==========================================
- Coverage   78.01%   78.00%   -0.01%     
==========================================
  Files         327      327              
  Lines       21284    21279       -5     
==========================================
- Hits        16604    16599       -5     
  Misses       3447     3447              
  Partials     1233     1233              
Impacted Files Coverage Δ
persistence/sql/identity/persister_identity.go 80.11% <66.66%> (-0.19%) ⬇️

@aeneasr aeneasr changed the title fix: correct expand in whoami call fix: incorrect override in identity hydrate Jul 6, 2023
@aeneasr aeneasr merged commit eaa3f3c into master Jul 6, 2023
26 checks passed
@aeneasr aeneasr deleted the fix-regression-expand branch July 6, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant