Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verificaton after registration #3451

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Aug 23, 2023

This fixes a bug in the session lookup after the verification hook ran and the OIDC challenge needs to be accepted.

Rather than looking up the session in the DB, we now pass along all information (session ID, identity ID, and AMR) to the verification hook so that the hook has all information to accept the login challenge on its own terms.

I verified that the E2E tests on Cloud pass with this change.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from jonas-jonas August 23, 2023 17:50
@hperl hperl self-assigned this Aug 23, 2023
zepatrik
zepatrik previously approved these changes Aug 23, 2023
aeneasr
aeneasr previously approved these changes Aug 23, 2023
@hperl hperl dismissed stale reviews from aeneasr and zepatrik via 1c7c92a August 24, 2023 06:23
@hperl hperl force-pushed the hperl/fix-kratos-verification branch from 5109fae to 1c7c92a Compare August 24, 2023 06:23
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #3451 (5503d5e) into master (e7b33a1) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 80.00%.

❗ Current head 5503d5e differs from pull request most recent head 1c7c92a. Consider uploading reports for the commit 1c7c92a to get more accurate results

@@            Coverage Diff             @@
##           master    #3451      +/-   ##
==========================================
- Coverage   78.05%   78.05%   -0.01%     
==========================================
  Files         327      327              
  Lines       21617    21615       -2     
==========================================
- Hits        16874    16872       -2     
- Misses       3484     3485       +1     
+ Partials     1259     1258       -1     
Files Changed Coverage Δ
selfservice/flow/verification/flow.go 92.00% <ø> (ø)
session/session.go 78.90% <50.00%> (-0.94%) ⬇️
selfservice/flow/verification/handler.go 65.69% <100.00%> (-0.52%) ⬇️
selfservice/hook/verification.go 78.72% <100.00%> (+0.94%) ⬆️

@hperl hperl merged commit 77c3196 into master Aug 24, 2023
28 checks passed
@hperl hperl deleted the hperl/fix-kratos-verification branch August 24, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants