Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not initialize parts of the registry in parallel #3534

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

zepatrik
Copy link
Member

...as this can lead to race conditions. We should in fact get rid of most "JIT" initialization in the registry, and where it makes sense at least add a lock or sync.Once.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #3534 (e7e9f8a) into master (7ae1271) will decrease coverage by 0.48%.
Report is 1 commits behind head on master.
The diff coverage is 67.56%.

❗ Current head e7e9f8a differs from pull request most recent head 1712c05. Consider uploading reports for the commit 1712c05 to get more accurate results

@@            Coverage Diff             @@
##           master    #3534      +/-   ##
==========================================
- Coverage   78.68%   78.20%   -0.48%     
==========================================
  Files         342      341       -1     
  Lines       23470    22767     -703     
==========================================
- Hits        18467    17806     -661     
+ Misses       3639     3623      -16     
+ Partials     1364     1338      -26     
Files Coverage Δ
cmd/daemon/serve.go 87.93% <67.56%> (-0.13%) ⬇️

... and 12 files with indirect coverage changes

@zepatrik zepatrik enabled auto-merge (squash) September 26, 2023 16:49
@zepatrik zepatrik merged commit ff177db into master Sep 26, 2023
30 checks passed
@zepatrik zepatrik deleted the fix/parallel-initialization branch September 26, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant