-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow importing hmac hashed passwords #3544
Conversation
cedfbcd
to
023d32f
Compare
023d32f
to
bf6b677
Compare
bf6b677
to
1b8b876
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! This looks very good for your first time writing Go! We'll need to do another pass on the security aspects but I doN't see any big blockers. @jonas-jonas WDYT?
Oh and could you please add docs for this here: https://github.com/ory/docs/edit/master/docs/kratos/manage-identities/25_import-user-accounts-identities.mdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice changes! Thanks for the patch!
Codecov Report
@@ Coverage Diff @@
## master #3544 +/- ##
==========================================
- Coverage 78.20% 78.12% -0.08%
==========================================
Files 341 341
Lines 22830 22870 +40
==========================================
+ Hits 17855 17868 +13
- Misses 3632 3654 +22
- Partials 1343 1348 +5
|
Oh wow! You move quick, @aeneasr – I was coming back to add in the documentation now |
Would still appreciate it if you could add a PR for docs :) Thanks so much! |
Done, @aeneasr – ory/docs#1580 |
Hello folks!
I've had a crack at implementing hmac support for password imports
I've followed the approach of base64 encoding and delimiting the string with
$
as seems to be the convention.The basic format is
$hmac-<hashfunction>$<base64 encoded hash>$<base64 encoded key>
e.g.:I yoinked a subset of the digests from Auth0
NB: This is my first time writing any Go, so please point out areas for improvement
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.