-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add value code to authentication method enum #3546
fix: add value code to authentication method enum #3546
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3546 +/- ##
=======================================
Coverage 78.20% 78.20%
=======================================
Files 341 341
Lines 22830 22830
=======================================
Hits 17855 17855
Misses 3632 3632
Partials 1343 1343 |
Hi @cpoyatos1, Thank you for the contribution! |
Done 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Can you estimate when the patch will be released? |
For |
I found an issue in the current client open api spec (v1.2.10).
Line 5740 - ref: "#/components/schemas/sessionAuthenticationMethod". There is the method "code" missing. For the new one-time code passwordless feature.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.