Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add value code to authentication method enum #3546

Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix: add value code to authentication method enum #3546

merged 2 commits into from
Oct 4, 2023

Conversation

cpoyatos1
Copy link
Contributor

@cpoyatos1 cpoyatos1 commented Oct 3, 2023

I found an issue in the current client open api spec (v1.2.10).
Line 5740 - ref: "#/components/schemas/sessionAuthenticationMethod". There is the method "code" missing. For the new one-time code passwordless feature.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

@cpoyatos1 cpoyatos1 marked this pull request as ready for review October 3, 2023 15:37
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #3546 (780c24f) into master (1b3647c) will not change coverage.
The diff coverage is n/a.

❗ Current head 780c24f differs from pull request most recent head 8730f3c. Consider uploading reports for the commit 8730f3c to get more accurate results

@@           Coverage Diff           @@
##           master    #3546   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files         341      341           
  Lines       22830    22830           
=======================================
  Hits        17855    17855           
  Misses       3632     3632           
  Partials     1343     1343           

@Benehiko
Copy link
Contributor

Benehiko commented Oct 4, 2023

Hi @cpoyatos1,

Thank you for the contribution!
To get this merged, you would need sign the contribution guidelines CLA as mentioned above.

@cpoyatos1
Copy link
Contributor Author

Done 👍🏼

Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@cpoyatos1
Copy link
Contributor Author

cpoyatos1 commented Oct 4, 2023

Can you estimate when the patch will be released?

@jonas-jonas
Copy link
Member

Can you estimate when the patch will be released?

For ory/client in the coming days :)

@Benehiko Benehiko merged commit 95dc7a2 into ory:master Oct 4, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants