Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect SMTP error handling #3636

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: incorrect SMTP error handling #3636

merged 1 commit into from
Nov 22, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Nov 22, 2023

No description provided.

@alnr alnr self-assigned this Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6d08576) 78.35% compared to head (9b96cdd) 78.41%.

Files Patch % Lines
courier/smtp.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3636      +/-   ##
==========================================
+ Coverage   78.35%   78.41%   +0.06%     
==========================================
  Files         344      344              
  Lines       23493    23493              
==========================================
+ Hits        18407    18422      +15     
+ Misses       3701     3687      -14     
+ Partials     1385     1384       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alnr alnr merged commit ee138ec into master Nov 22, 2023
30 of 31 checks passed
@alnr alnr deleted the fix-smtp-errors branch November 22, 2023 15:00
moose115 pushed a commit to moose115/kratos that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants