Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract identifier label for login from default identity schema #3645

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

zepatrik
Copy link
Member

closes #3041

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (c25ddff) 78.40% compared to head (8b33a1e) 78.37%.

Files Patch % Lines
...lfservice/flow/login/extension_identifier_label.go 86.66% 2 Missing and 2 partials ⚠️
selfservice/strategy/code/strategy.go 42.85% 2 Missing and 2 partials ⚠️
selfservice/strategy/code/strategy_login.go 42.85% 2 Missing and 2 partials ⚠️
selfservice/strategy/password/login.go 42.85% 2 Missing and 2 partials ⚠️
selfservice/strategy/webauthn/login.go 42.85% 2 Missing and 2 partials ⚠️
schema/extension.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3645      +/-   ##
==========================================
- Coverage   78.40%   78.37%   -0.04%     
==========================================
  Files         344      345       +1     
  Lines       23494    23558      +64     
==========================================
+ Hits        18421    18463      +42     
- Misses       3688     3699      +11     
- Partials     1385     1396      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zepatrik zepatrik merged commit 180828e into master Dec 1, 2023
28 of 29 checks passed
@zepatrik zepatrik deleted the feat/login-id-label branch December 1, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow's returning "ID" instead of "Email" for label text
3 participants