Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore decrypt errors in WithDeclassifiedCredentials #3731

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Feb 2, 2024

Should solve 500s on identity details, if the identity was registered using native social sign in flows, and the OIDC credential doesn't contain tokens.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr enabled auto-merge (squash) February 5, 2024 09:58
@aeneasr aeneasr force-pushed the jonas-jonas/ignoreDecryptErrors branch from 7046c1a to 25a6ba4 Compare February 5, 2024 14:27
@aeneasr aeneasr force-pushed the jonas-jonas/ignoreDecryptErrors branch from 25a6ba4 to 4a47472 Compare February 5, 2024 15:39
@aeneasr aeneasr merged commit 8f5192f into master Feb 22, 2024
25 of 27 checks passed
@aeneasr aeneasr deleted the jonas-jonas/ignoreDecryptErrors branch February 22, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants