Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transient payloads to all flows #3738

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (40ed809) 78.39% compared to head (7cd0d7a) 78.37%.
Report is 1 commits behind head on master.

❗ Current head 7cd0d7a differs from pull request most recent head a3f766d. Consider uploading reports for the commit a3f766d to get more accurate results

Files Patch % Lines
selfservice/strategy/code/code_sender.go 60.97% 11 Missing and 5 partials ⚠️
selfservice/strategy/link/sender.go 80.95% 4 Missing and 4 partials ⚠️
selfservice/flow/settings/flow.go 0.00% 2 Missing ⚠️
selfservice/strategy/oidc/strategy_settings.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3738      +/-   ##
==========================================
- Coverage   78.39%   78.37%   -0.02%     
==========================================
  Files         347      348       +1     
  Lines       23911    23977      +66     
==========================================
+ Hits        18745    18792      +47     
- Misses       3755     3767      +12     
- Partials     1411     1418       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas marked this pull request as ready for review February 16, 2024 12:46
@aeneasr aeneasr merged commit b8b747b into master Feb 21, 2024
28 checks passed
@aeneasr aeneasr deleted the jonas-jonas/transientPayloads branch February 21, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants