Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add login succeeded event to post registration hook #3739

Merged

Conversation

sashatalalasha
Copy link
Contributor

This PR adds NewLoginSucceeded event to post registration hook

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@sashatalalasha sashatalalasha marked this pull request as ready for review February 5, 2024 13:09
@aeneasr aeneasr force-pushed the fix/add-event-post-registration-hook branch from 387f40a to 8a59804 Compare February 5, 2024 14:30
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@087748c). Click here to learn what that means.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3739   +/-   ##
=========================================
  Coverage          ?   78.39%           
=========================================
  Files             ?      348           
  Lines             ?    24011           
  Branches          ?        0           
=========================================
  Hits              ?    18823           
  Misses            ?     3769           
  Partials          ?     1419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr force-pushed the fix/add-event-post-registration-hook branch from b1d436a to e9d2855 Compare February 22, 2024 09:31
@aeneasr aeneasr merged commit b685fa5 into ory:master Feb 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants